Skip to content

chore: memoize tabs children #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lawreka merged 2 commits into from
Jan 30, 2026
Merged

chore: memoize tabs children #188

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
292a34b
memoize tab children and ids
lawreka Jan 30, 2026
7a25460
fmt
lawreka Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 18 additions & 9 deletions packages/components/src/components/tabs/tabs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import {
useCallback,
useEffect,
useId,
useMemo,
useRef,
useState,
} from "react";
Expand Down Expand Up @@ -69,18 +70,26 @@ const TabsRoot = ({
const tabRefs = useRef<(HTMLLIElement | null)[]>([]);
const uniqueId = useId();

const arrayChildren = Children.toArray(children).filter(
(child): child is ReactElement<TabsItemProps> => isValidElement(child)
const arrayChildren = useMemo(
() =>
Children.toArray(children).filter(
(child): child is ReactElement<TabsItemProps> => isValidElement(child)
),
[children]
);

const tabIds = arrayChildren.map((child, index) => {
if (child.props.id) {
return child.props.id;
}
const tabIds = useMemo(
() =>
arrayChildren.map((child, index) => {
if (child.props.id) {
return child.props.id;
}

const tabId = child.props.title ?? DEFAULT_TAB_TITLE;
return `${uniqueId}-${slugify(tabId)}-${index}`;
});
const tabId = child.props.title ?? DEFAULT_TAB_TITLE;
return `${uniqueId}-${slugify(tabId)}-${index}`;
}),
[arrayChildren, uniqueId]
);

const validDefaultTabIndex =
arrayChildren.length > 0
Expand Down