Skip to content

Bundle shiki worker #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lindsayzhng merged 2 commits into from
Feb 4, 2026
Merged

Bundle shiki worker #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
291db2b
bundle shiki worker
lindsayzhng Feb 4, 2026
2bbfe63
simplify bundle path and use relative
lindsayzhng Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions packages/components/src/utils/shiki/worker-client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,19 @@ function getShikiWorker(): ShikiWorkerInstance {
if (instance) {
return instance;
}
const worker = new Worker(new URL("./worker.js", import.meta.url), {
type: "module",
});
instance = wrap(worker);
return instance;
try {
const worker = new Worker(new URL("./worker.js", import.meta.url), {
type: "module",
});
instance = wrap(worker);
return instance;
} catch (error) {
console.warn(
"@mintlify/components: Shiki worker unavailable, using synchronous highlighting",
error
);
return undefined;
}

@cursor cursor Bot Feb 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repeated worker creation attempts on failure

Medium Severity

When worker creation fails in the catch block, instance remains undefined. This causes every subsequent call to getShikiWorker() to retry creating the worker, fail again, and log another warning. Since this function is called for every large code block, this can result in console spam and unnecessary overhead. The failed initialization state needs to be tracked to prevent repeated retry attempts.

Fix in Cursor Fix in Web

}

export { getShikiWorker };
8 changes: 8 additions & 0 deletions packages/components/vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { defineConfig } from "vite";
import dts from "vite-plugin-dts";

export default defineConfig({
base: "",
plugins: [
react(),
tailwindcss(),
Expand All @@ -26,6 +27,13 @@ export default defineConfig({
},
worker: {
format: "es",
rollupOptions: {
external: [],
output: {
entryFileNames: "utils/shiki/worker.js",
inlineDynamicImports: true,
},
},
},
build: {
lib: {
Expand Down