Fix security dependency alerts and lock CI builds - #15
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: be3939f946
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| with: | ||
| tool: cargo-audit | ||
| - run: cargo audit | ||
| - run: cargo audit --locked |
There was a problem hiding this comment.
Remove unsupported --locked from cargo audit
When the CI audit job runs, this invocation passes --locked to the external cargo-audit binary rather than to Cargo itself; cargo --help shows --locked as a top-level Cargo option before COMMAND, and RustSec's current cargo-audit CLI options do not define a --locked flag. As a result, the audit job will fail on argument parsing before scanning Cargo.lock, so the security check is broken instead of locked.
Useful? React with 👍 / 👎.
Motivation
serde_yamlby switching to a maintained YAML backend compatible with existing imports.Description
serde_yamldependency withserde_yaml_ngwhile keeping theserde_yamlcrate name in manifests by using a package alias inCargo.tomlandfuzz/Cargo.toml.Cargo.tomlandCargo.lock(Wasmtime ->43.0.1, Cranelift ->0.130.1,gimli->0.33.0, and related lockfile adjustments) to move off deprecated/yanked selections.--lockedto cargo invocations across.github/workflows/ci.ymland.github/workflows/security.yml(tests, build, clippy, nextest, llvm-cov, audit/deny/geiger, miri, benches, etc.).Testing
cargo fmt --all --check, which succeeded.git diff --checkandcargo metadata --locked --format-version=1 --no-deps, both succeeded and validated workspace/lockfile coherence checks.rgpatterns to verifyserde_yaml/Wasmtime/Cranelift changes, which matched the expected replacements.cargo check --locked --workspace --all-features, but the run was blocked by the environment failing to download crates from crates.io (network/proxy returnedCONNECT tunnel failed, response 403), so a full locked build could not be completed in this environment.Codex Task