-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docstrings to Octopoes models #4038
Conversation
Co-authored-by: ammar92 <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stephanie0x00 Cool! I agree with @ammar92 that "Represents" would be better than "Returns". I guess these text show up on the octopoes model documentation page? Is the idea to extend this PR with docstrings for more of the suggested models in the ticket?
Yes, all models should, in the end, contain docstring data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is helpfull! Some tiny remarks. Overall, I think we can expand the docstrings to make them a bit more insightful, what do they do? when are they used? what do they actually show?
Also, I'm missing the oois in the DNS folder.
…s now they have docstrings; the information is rendered correctly.
|
Changes
This PR adds docstrings to extend the Octopoes model.
Issue link
Issue: #2946
Closes #2946
Demo
n/a
QA notes
I've tried to describe all objects as best as I could. I'm fairly sure some are somewhat incorrect and/or miss data. This is the best I could do. The goal is to provide both Possible value/Example values where possible to make it more clear on what the object is, accepts, can do etc. etc. Please help me to enhance the PR. :)
Code Checklist
.env
changes files if required and changed the.env-dist
accordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.