Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docstrings to Octopoes models #4038

Merged
merged 18 commits into from
Mar 28, 2025

Conversation

stephanie0x00
Copy link
Contributor

@stephanie0x00 stephanie0x00 commented Jan 21, 2025

Changes

This PR adds docstrings to extend the Octopoes model.

Issue link

Issue: #2946

Closes #2946

Demo

n/a

QA notes

I've tried to describe all objects as best as I could. I'm fairly sure some are somewhat incorrect and/or miss data. This is the best I could do. The goal is to provide both Possible value/Example values where possible to make it more clear on what the object is, accepts, can do etc. etc. Please help me to enhance the PR. :)


Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@stephanie0x00 stephanie0x00 requested a review from a team as a code owner January 21, 2025 12:01
@stephanie0x00 stephanie0x00 marked this pull request as draft January 21, 2025 12:01
Copy link

sonarqubecloud bot commented Feb 4, 2025

Copy link
Contributor

@Donnype Donnype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stephanie0x00 Cool! I agree with @ammar92 that "Represents" would be better than "Returns". I guess these text show up on the octopoes model documentation page? Is the idea to extend this PR with docstrings for more of the suggested models in the ticket?

@stephanie0x00
Copy link
Contributor Author

@stephanie0x00 Cool! I agree with @ammar92 that "Represents" would be better than "Returns". I guess these text show up on the octopoes model documentation page? Is the idea to extend this PR with docstrings for more of the suggested models in the ticket?

Yes, all models should, in the end, contain docstring data.

@stephanie0x00 stephanie0x00 marked this pull request as ready for review March 6, 2025 17:31
Copy link
Contributor

@noamblitz noamblitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is helpfull! Some tiny remarks. Overall, I think we can expand the docstrings to make them a bit more insightful, what do they do? when are they used? what do they actually show?

Also, I'm missing the oois in the DNS folder.

@Donnype Donnype added the 😸 Review/QA feedback Review/QA feedback provided label Mar 21, 2025
@stephanie0x00 stephanie0x00 removed the 😸 Review/QA feedback Review/QA feedback provided label Mar 26, 2025
@Donnype Donnype self-assigned this Mar 27, 2025
…s now they have docstrings; the information is rendered correctly.
@Donnype
Copy link
Contributor

Donnype commented Mar 27, 2025

In the process of fixing the CI; consider this QA'd ;)

Schermafbeelding 2025-03-27 om 15 21 52 PM

@underdarknl underdarknl merged commit 6edb97c into main Mar 28, 2025
42 checks passed
@underdarknl underdarknl deleted the docs/extend-octopoes-object-definitions branch March 28, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Extend Octopoes documentation with object definitions
5 participants