Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging configuration options #4119

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

dekkers
Copy link
Contributor

@dekkers dekkers commented Feb 20, 2025

Changes

This improves logging configuration:

  • Add LOG_LEVEL setting to all services.
  • Add LOG_RICH_EXCEPTIONS setting with defaulting to off. The reason is that the rich exceptions are huge and we saw that it can even cause timeouts during development. It can also log secrets because it logs all the variables in the stack trace.

QA notes

Please add some information for QA on how to test the newly created code.


Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
11.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Incoming features / Need assessment
Development

Successfully merging this pull request may close these issues.

1 participant