Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change OOI types for findings report #4184

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

stephanie0x00
Copy link
Contributor

Changes

This PR limits the user to generate a findings report for only hostnames and IP addresses.

Issue link

n/a

Demo

image

QA notes

Verify that Finding reports can generated.


Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

Sorry, something went wrong.

@stephanie0x00 stephanie0x00 requested a review from a team as a code owner March 18, 2025 15:10
@noamblitz
Copy link
Contributor

noamblitz commented Mar 19, 2025

I suggest we are careful with merging this PR since it would break this flow (Bevindingen report genereren)

image

@underdarknl
Copy link
Contributor

@noamblitz I agree, however, that button should only be there if there are report-types available for the currently viewed OOI-Type. And if multiple, it should present a dropdown / selection page to select the desired Report-type. @RomijnHumanoids Did you have a design for that step somewhere?

@noamblitz
Copy link
Contributor

noamblitz commented Mar 20, 2025

image

added this for hostnames (changed name to "Generate Report")

image

doenst show up for network

@noamblitz noamblitz self-assigned this Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Review
Development

Successfully merging this pull request may close these issues.

None yet

5 participants