Add time to observed_at #4227
Open
Add time to observed_at #4227
+89
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ammar92
reviewed
Mar 29, 2025
| except ValueError: | ||
| messages.error(self.request, _("Can not parse date, falling back to show current date.")) | ||
| return datetime.now(timezone.utc) | ||
| observed_at = datetime.fromisoformat(observed_at_string).replace(tzinfo=timezone.utc) |
There was a problem hiding this comment.
A minor optimization, but the problem here is in the case of a missing request parameter, you already have a ISO formatted UTC timestamp (due to line 86). Reparsing the already formatted string seems redundant. Another way to do this is (in pseudocode):
if "observed_at" in self.request.GET:
observed_at = datetime.fromisoformat(self.request.GET['observed_at']).replace(tzinfo=timezone.utc)
else:
observed_at = datetime.now(timezone.utc)
Comment on lines
+108
to
+109
| context["observed_at"] = self.observed_at.strftime("%Y-%m-%d %H:%M") | ||
| context["observed_at_human_readable"] = self.observed_at.strftime("%B %d, %Y, %H:%M (%Z)") |
There was a problem hiding this comment.
Since datetime formatting can be handled in the template, introducing two new variables for this looks redundant to me. I suggest applying formatting directly in the template instead
Comment on lines
+168
to
+169
| context["observed_at"] = self.observed_at.strftime("%Y-%m-%d %H:%M") | ||
| context["observed_at_human_readable"] = self.observed_at.strftime("%B %d, %Y, %H:%M (%Z)") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
nowtimeIssue link
#4225
Closes #4225
Demo
QA notes
Mute a finding and then filter for "show muted findings"
You should see the muted finding in the list. Before this was not possible.
Code Checklist
.envchanges files if required and changed the.env-distaccordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.