Skip to content

Action for automatic uploading of Debian packages as release assets #4288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 6, 2025

Conversation

Donnype
Copy link
Contributor

@Donnype Donnype commented Apr 3, 2025

Changes

Automate adding the Debian packages to a release in the release pipeline.

Issue link

Demo

From my own fork, see this action:
https://github.com/Donnype/nl-kat-coordination/actions/runs/14243643179

And the resulting v0.18.2 release including the necessary assets and the automatically generated release notes:
https://github.com/Donnype/nl-kat-coordination/releases/tag/v0.18.2

QA notes

This unfortunately cannot be QA'd, except by testing if the debian packages work after the next release.


Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@Donnype Donnype marked this pull request as ready for review April 3, 2025 13:07
@Donnype Donnype requested a review from a team as a code owner April 3, 2025 13:07
@Donnype Donnype changed the title V1 for automatic release asset uploads for the various debian packages Action for automatic uploading of Debian packages as release assets Apr 3, 2025
Copy link
Contributor

@dekkers dekkers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The debian tarball currently also includes the kat-cveapi deb package, but that shouldn't be in there.

Move the cve-api out of the debian tarbal
@Donnype
Copy link
Contributor Author

Donnype commented Apr 6, 2025

Copy link

sonarqubecloud bot commented Apr 6, 2025

@dekkers dekkers merged commit 796d8e3 into main Apr 6, 2025
32 checks passed
@dekkers dekkers deleted the feature/poc-debian-package-upload-workflow branch April 6, 2025 13:34
Donnype added a commit that referenced this pull request Apr 14, 2025
ghost pushed a commit that referenced this pull request Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants