migrate to python3, pyproject.toml #72
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwidman
approved these changes
Aug 12, 2024
Contributor
jeffwidman
left a comment
jeffwidman
left a comment
There was a problem hiding this comment.
👍 for dropping py2 support... makes life simpler for sure.
| language: python | ||
| python: | ||
| - 2.7 | ||
| - 3.6 |
Contributor
There was a problem hiding this comment.
If we're going for Python 3, should we also go for a non-deprecated 3 version? Or are you planning to tackle that in a follow-on PR?
Author
There was a problem hiding this comment.
Yea I agree, just wasn't sure if CI is still running (or honestly if the project is still being maintained)
Would it make sense to just migrate to github actions? Can do that here or in a separate PR (whichever you prefer)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops python 2 support and migrates to
pyproject.toml(the modern replacement forsetup.py)