Lock on building bundles with the same output target#515
Open
SpeedProg wants to merge 1 commit intomiracle2k:masterfrom
Open
Lock on building bundles with the same output target#515SpeedProg wants to merge 1 commit intomiracle2k:masterfrom
SpeedProg wants to merge 1 commit intomiracle2k:masterfrom
Conversation
Owner
|
Thanks for the PR. I think a locking system is a sensible improvement for this case, but I think this is incomplete as-is. It would only work when using a threaded model, but not if the workers are forked. To handle multiple processes competing, the lock has to be filesystem based, really; a threading lock is not enough. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into problems with the autobuild starting the build progress so often that the server ran out of memory (from all the node instances).
So here is my solution to preventing this from happening