Skip to content

Improve cross-platform compatibility in tests (Windows support)#562

Merged
greyli merged 1 commit intomiracle2k:masterfrom
denini08:fix-windows
Aug 17, 2025
Merged

Improve cross-platform compatibility in tests (Windows support)#562
greyli merged 1 commit intomiracle2k:masterfrom
denini08:fix-windows

Conversation

@denini08
Copy link
Copy Markdown
Contributor

@denini08 denini08 commented Aug 7, 2025

Hello! While running the test suite on Windows, I noticed that some assertions involving file paths fail due to path formatting differences (e.g., backslashes vs slashes, drive letters).

To address this and improve cross-platform compatibility:

  • I added a normalize_paths() helper to standardize paths using os.path.normpath().
  • I updated the affected tests to use this normalization when comparing file paths.
  • I also added a @pytest.mark.skipif for a test that uses a colon (:) in the filename, which is not allowed on Windows.

These changes should help ensure the test suite runs successfully across different platforms.

Let me know if you'd like anything adjusted. happy to help!

@greyli greyli merged commit 58b9b1b into miracle2k:master Aug 17, 2025
5 of 6 checks passed
@greyli
Copy link
Copy Markdown
Collaborator

greyli commented Aug 17, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants