Skip to content

Add support for --sleep in importImages - #156

Merged
Universal-Omega merged 1 commit into
miraheze:mainfrom
BlankEclair:mwimport-images-sleep
Jul 14, 2025
Merged

Add support for --sleep in importImages#156
Universal-Omega merged 1 commit into
miraheze:mainfrom
BlankEclair:mwimport-images-sleep

Conversation

@BlankEclair

@BlankEclair BlankEclair commented Jul 14, 2025

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • New Features

    • Added an option to automatically determine the delay between image imports based on the number of files present.
    • Introduced a new command-line argument to manually set the sleep duration between importing images.
  • Tests

    • Added and updated tests to verify the new and existing image import sleep functionality.

@coderabbitai

coderabbitai Bot commented Jul 14, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

A dynamic sleep interval feature was added to the image import process in the mwimport tool. This introduces a new command-line argument, --images-sleep, which allows manual or automatic configuration of the sleep duration between image imports, based on the number of files in the images directory. Corresponding tests were added and updated.

Changes

File(s) Change Summary
miraheze/mediawiki/mwimport.py Added --images-sleep argument, logic for automatic sleep calculation, and updated script generation.
tests/test_mwimport.py Added tests for --images-sleep argument and updated script expectation tests for sleep flag.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ArgParser
    participant MWImport
    participant FileSystem

    User->>ArgParser: Run mwimport with --images and optional --images-sleep
    ArgParser->>MWImport: Parse arguments
    MWImport->>FileSystem: (If --images-sleep < 0) Count image files
    FileSystem-->>MWImport: Return file count
    MWImport->>MWImport: Calculate sleep (1 if count >= threshold, else 0)
    MWImport->>MWImport: Prepare importImages script with --sleep flag
Loading

Possibly related PRs

  • miraheze/python-functions#119: Adds foundational argument parsing and script generation logic that the current PR extends with dynamic sleep time calculation for image imports.

Suggested reviewers

  • RhinosF1

Poem

A bunny paused between each hop,
To let the images gently drop.
With sleep set smart or by your hand,
It counts the files across the land.
Now imports rest, then onward leap—
Hopping code that knows when to sleep! 🐇


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7c7f16e and 426f656.

📒 Files selected for processing (2)
  • miraheze/mediawiki/mwimport.py (4 hunks)
  • tests/test_mwimport.py (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • miraheze/mediawiki/mwimport.py
  • tests/test_mwimport.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: build (3.11)
  • GitHub Check: build (3.13)
  • GitHub Check: build (3.14-dev)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@BlankEclair
BlankEclair force-pushed the mwimport-images-sleep branch from 7c7f16e to 426f656 Compare July 14, 2025 07:44
@Universal-Omega
Universal-Omega merged commit 1cdf536 into miraheze:main Jul 14, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants