tools: python3 only - #126
Open
toastal wants to merge 3 commits into
Open
Conversation
It’s infeasible to try to keep versions support up to date with Nixpkgs… this add a complicated patchelf script to the build, but for users, now they can just use latest python3, or easily override it.
C binary has less overhead than a shell script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to use
overlay.nix(non-flakes) withnixpkgs-unstable(NixOS 26.11 (Zokor)) which is a year ahead of what’s pinned here.python310was dropped in 26.05 & a bunch of new versions have been added since… & really this just seems like the wrong abstraction when you could just stick topython3, & eliminate all thegdbs that don’t match thepython3‘slibpythonversion. Instead, if you want a different/specificpython3,overrideit. Added an assert as more flexible & matches-upstream approach as well. …& swapped tomakeBinaryWrapperto drop shell overhead.NOTE: the 6.x branches need to bump the minimum Python version to 3.10, but unfortunately, those aren’t merged yet.
1
Footnotes
Please consider giving up MS GitHub or offering a non-proprietary, non-US-corporate-controlled mirror for this free software project. I wish to delete this Microsoft account in the future, but I need more projects like this to support alternative methods to send patches & contribute. ↩