Export ESP_IDF_VERSION in the setup hook - #134
Open
mornepousse wants to merge 1 commit into
Open
Conversation
Derived as major.minor, matching ESP-IDF's own tools/idf_tools.py, which matches '^v([0-9]+\.[0-9]+).*' against version.txt. Components such as esp_wifi_remote — the Wi-Fi path for the ESP32-P4 — compare against that two-part form, so emitting the patch level would not help them. Fixes mirrexagon#124.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #124.
ESP_IDF_VERSIONis currently unset in the dev shells, which breaks componentsthat branch on it — the issue reporter hit this with
esp_wifi_remote, wheremissing configs make the build fail.
The value is derived the same way ESP-IDF derives it itself, in
tools/idf_tools.py:so major.minor only. That matters: emitting the patch level (
5.5.2ratherthan
5.5) would still leave a comparison against the two-part form failing,which is also the form the reporter says works for them.
Tested on x86_64-linux with
esp-idf-full: