Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add milvus example mistral french parliament #39

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

stephen37
Copy link

@stephen37 stephen37 commented May 29, 2024

This is an example of how one can build a RAG app and interact with data from the French parliament using Milvus as the Vector DB an Mistral as the LLM in combination with Ollama.

stephen37 added 4 commits May 23, 2024 20:59
This example showcases how you can use Milvus Lite and Llama Index to
build a RAG system. It is using data from the French parliament.
@sophiamyang
Copy link
Collaborator

Hi @stephen37 thanks for contributing! could you add the notebook to the third-party integrations folder and could you use Mistral embeddings? Thanks!

@pandora-s-git
Copy link
Collaborator

pandora-s-git commented Jun 10, 2024

Since the issue seems to be the fact that the data is originally French we could switch to a different one in English.

@stephen37
Copy link
Author

Hi @stephen37 thanks for contributing! could you add the notebook to the third-party integrations folder and could you use Mistral embeddings? Thanks!

Hey @sophiamyang, I moved it to the third party folder and changed to Mistral Embeddings, let me know what you think now 🙏

@stephen37
Copy link
Author

Hey @sophiamyang, do you think it's good to merge now? 😄

@sophiamyang
Copy link
Collaborator

Hi @stephen37 , thank you so much for the cookbook! We are ready to merge this cookbook! However, I got an error:
ValueError: ServiceContext is deprecated. Use llama_index.settings.Settings instead,

Could you help update the syntax and tag the package version in case llamaindex has more changes? Also, wondering if you could help add another example using Mistral API in addition to Ollama? Thanks so much!

@stephen37
Copy link
Author

@sophiamyang Sorry for the delay, I was on holiday last week but I pushed a new commit addressing your concerns, let me know what you think :)

@sophiamyang
Copy link
Collaborator

Hi @stephen37 , thanks so much for the updates!! Looks good. However, I got an error message: "ValueError: File data/french_parliament_discussion.xml does not exist.". Could you help fix? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants