Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(List): Add pre-filtering to list #1256

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat(List): Add pre-filtering to list #1256

wants to merge 2 commits into from

Conversation

TimAufdemKampe
Copy link
Member

Closes #1177

@TimAufdemKampe TimAufdemKampe linked an issue Mar 10, 2025 that may be closed by this pull request
Open pre-filtered list #1177
Open
@TimAufdemKampe TimAufdemKampe changed the title fix(List): Remove not existing style class fix(List): Add pre-filtering to list Mar 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report for ./packages/components/

Status Category Percentage Covered / Total
🔵 Lines 27.47% 4535 / 16507
🔵 Statements 27.47% 4535 / 16507
🔵 Functions 38.42% 380 / 989
🔵 Branches 57.07% 694 / 1216
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/components/src/components/List/List.tsx 74.01% 40.9% 100% 74.01% 65-68, 70-73, 87-89, 93-95, 112-116, 129-142
packages/components/src/components/List/model/filter/Filter.ts 68.42% 75% 78.12% 68.42% 90, 102-103, 112, 114-116, 122, 148-150, 157-161, 178, 187-188, 191-205, 227-228, 235-250, 253-255, 258-276
packages/components/src/components/List/model/filter/types.ts 100% 100% 100% 100%
packages/components/src/components/List/stories/Default.stories.tsx 0% 0% 0% 0% 1-220
packages/components/src/components/List/stories/EdgeCases.stories.tsx 0% 0% 0% 0% 1-357
Generated in workflow #2184 for commit 1fc7d9a by the Vitest Coverage Report Action

@TimAufdemKampe TimAufdemKampe changed the title fix(List): Add pre-filtering to list feat(List): Add pre-filtering to list Mar 10, 2025
Lisa18289
Lisa18289 reviewed Mar 10, 2025
View reviewed changes
packages/components/src/components/List/stories/EdgeCases.stories.tsx
return (
<SettingsProvider storageKey="domainList" type="localStorage">
<Section>
<Alert>This two lists have the same settingsKey ("Domains")</Alert>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These statt this

packages/components/src/components/List/stories/EdgeCases.stories.tsx
/>
</DefaultDomainList>

<Heading>Fixed filters</Heading>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ich glaub ich check den Sinn der Sache noch nicht, das kommt doch aufs gleiche raus wie mit dem defaultSelected (außer dass es die User Settings überschreibt)

ich hät jetzt eher vermutet dass man die selected filter dann auch garnicht rausnehmen kann

@TimAufdemKampe TimAufdemKampe marked this pull request as draft March 10, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lisa18289 Lisa18289 Lisa18289 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Open pre-filtered list
2 participants
@TimAufdemKampe @Lisa18289