fix(schematic): respect intentional unconnected pins - #267
Open
nordic-style wants to merge 1 commit into
Open
Conversation
nordic-style
force-pushed
the
codex/fix/component-connection-pin-types
branch
from
August 17, 2026 23:02
846e652 to
1e4c5e7
Compare
This was referenced Aug 18, 2026
The component validator reported pins declared no-connect, ignored its public power-pin option, and projected every unit's pins through each placed unit. Preserve KiCad electrical types, honor the filter, exempt explicit and intrinsic no-connect pins, and resolve only the selected unit. Refs mixelpixx#182
nordic-style
force-pushed
the
codex/fix/component-connection-pin-types
branch
from
August 18, 2026 00:33
1e4c5e7 to
2de4473
Compare
Owner
|
This and #280 add the identical |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stop
validate_component_connectionsfrom reporting intentionally unconnected symbol pins and pins belonging to other units, and make the existingignore_power_pinsoption effective.Refs #182
Approach
no_connectas well as ordinary pins carrying a schematic no-connect marker.ignore_power_pinsforpower_inandpower_outpins.pin_typeto each reported finding and clarify the public tool description.This is the validator-specific part of #182. #272 covers the remaining analysis/export/review paths and #273 covers reference-based component mutations.
Compatibility and safety
The request schema is unchanged. Findings gain an additive
pin_typefield. Results intentionally stop containing library-declared NC pins, ignored power pins, and pins from unplaced units.This validator is read-only and does not alter the schematic.
Validation
cargo fmt --all -- --check: passcargo clippy -p konnect-core -p konnect-sexp --locked --all-targets -- -D warnings: passcargo test -p konnect-sexp --locked: 134 unit tests, 8 property tests, and 6/7 doc tests pass (1 ignored)cargo test -p konnect-core --locked --lib midwire_pin_tests: 3 pass, covering declared NC, power filtering, selected units, and mid-wire junction behaviorupdate_symbols_from_library_*failures reproduce onorigin/mainbecause the installed KiCadDevice:Rlibrary shadows the fixtureNC; the patched validator reported 0 on the same saved inputReview checklist
docs/NAMING_CONVENTIONS.md; public renames include compatibility handling.