Skip to content

fix(api): remove ignored tool parameters - #278

Open
nordic-style wants to merge 1 commit into
mixelpixx:mainfrom
nordic-style:codex/fix/remove-ignored-tool-inputs
Open

fix(api): remove ignored tool parameters#278
nordic-style wants to merge 1 commit into
mixelpixx:mainfrom
nordic-style:codex/fix/remove-ignored-tool-inputs

Conversation

@nordic-style

Copy link
Copy Markdown
Contributor

User-visible problem and scope

Eight optional MCP inputs were advertised even though their handlers never read them. A caller could reasonably believe those values changed validation, costing, review, hierarchy, zone refill, or manufacturing output when they did nothing.

This PR removes only those dead inputs, corrects overstated descriptions, and records a supported replacement workflow for every removal.

Refs #251

Root cause and design

Schemas and handlers evolved independently. The unused fields survived because existing tests checked registration and required arguments, but not whether every advertised property reached implementation behavior.

The schemas now match the operations Konnect can verify. docs/API_MIGRATIONS.md is the explicit compatibility record, and schema_migrations.rs prevents a removed field from returning without a migration note.

Compatibility and migration

Removed fields:

  • import_sheet_pins.project_name
  • refill_zones.zones
  • run_drc.tests
  • audit_decoupling.board
  • audit_decoupling.max_distance_mm
  • export_manufacturing_package.quantity
  • validate_for_manufacturing.schematic
  • estimate_cost.schematic

All were optional and behaviorally inert, so generated files and analysis results are unchanged. The migration document points callers to project-instance workflows, complete-board zone refill, KiCad DRC configuration, PCB placement inspection, estimate_cost.quantity, check_bom_health, and board-footprint counting as appropriate.

Validation

  • cargo test -p konnect --test schema_migrations --locked
  • cargo clippy --workspace --locked --all-targets -- -D warnings
  • cargo fmt --all -- --check
  • Combined-series CI commands: docs, Clippy, and format pass; 585/588 konnect-core tests pass, with only the same three installed-Device:R fixture-shadowing failures reproduced on unmodified main.

Risk and rollback

The intentional API narrowing may expose clients that were sending inert fields. Migration is omission or the documented companion tool; no data format or file write changes. Rollback is one commit, including the migration and regression test.

Narrow eight schemas to behavior their handlers can verify, correct overstated tool descriptions, and document a replacement workflow for every public input removal.

Refs mixelpixx#251
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant