fix(guidance): bind manufacturing claims to evidence - #366
Merged
neusse merged 1 commit intoAug 30, 2026
Conversation
This was referenced Aug 29, 2026
Collaborator
Author
|
Post-review follow-up #377 tracks the minor remaining ambiguity in the literal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and scope
PRs #362 and #363 connected the Claude package and made its claimed evidence executable, but the final #357 scope remained: manufacturing guidance still credited
validate_for_manufacturingwith checks it does not perform, treated partial exports as complete packages, duplicated conflicting vendor tables, and presented fixed trace/via/impedance geometry without the inputs required to justify it.This is the focused guidance-only PR C. It closes the remaining #357 scope without depending on the conflicting #270 branch.
Design
INCOMPLETE.estimate_costas an indicative fixed-assumption heuristic rather than a quote.The wording is deliberately forward-compatible with #270: if a future response exposes a verified artifact manifest, the skill accepts that stronger evidence only for the postconditions it names. The viewer and order-preview gates remain.
Compatibility
Bundled Claude skills, references, and their asset tests change. MCP tools, schemas, response shapes, Rust export behavior, file formats, installer paths, and Codex behavior are unchanged. Because #270 edits Rust export modules while this PR edits bundled Markdown and
asset_references.rs, there is no expected textual conflict.Validation
Red baseline before the guidance rewrite:
cargo test -p konnect --test asset_references manufacturing_guidance_is_contract_bound_and_fail_closedpresence of at least one Edge.Cuts item)After the rewrite:
cargo test -p konnect --test asset_references: 12/12 passedcargo fmt --all -- --check: passedcargo clippy --workspace --locked --all-targets -- -D warnings: passedcargo test --workspace --locked --lib --tests: passedcargo test --workspace --locked --doc: passedReal-KiCad GUI, installed-library, Java/Freerouting, and dedicated E2E cases remain ignored where their existing tests require those environments. This PR changes guidance only and does not claim those environment-dependent paths were exercised.
Risk and rollback
The workflow asks for more explicit evidence before manufacturing approval, which adds agent work to a full fabrication handoff. That work corresponds to checks the previous guidance already claimed had happened. The change can be reverted without data or API migration.
Closes #357.