Skip to content

feat: add QML setting popup #14568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025
Merged

Conversation

acolombier
Copy link
Member

@acolombier acolombier commented Mar 30, 2025

Add QML setting section popup. Note that the legacy setting window can still be displayed by long pressing the setting button.

This also add a setup to allow setting search. Currently, setting search activation will automatically activate the setting in the UI, but it is also to bind the Mixxx.SettingGroup.onActivated signal to add more animation (e.g to highligh an input/output in the soundgraph)

@acolombier acolombier force-pushed the feat/qml-settings branch 3 times, most recently from 3ec8f11 to e053834 Compare April 7, 2025 06:43
@acolombier acolombier force-pushed the feat/qml-settings branch 2 times, most recently from 3f7eabe to 5c31c41 Compare May 6, 2025 08:20
@acolombier acolombier marked this pull request as ready for review May 6, 2025 08:23
@acolombier acolombier added this to the 3.0-beta milestone May 6, 2025
@github-project-automation github-project-automation bot moved this to In progress in QML GUI May 6, 2025
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple thoughts. overall pretty nice. Building locally right now to sanity test.

@acolombier
Copy link
Member Author

pre-commit failures depend on qarmin/qml_formatter#7

color: Qt.alpha('#00000010', hasHardwareAcceleration ? 1.0 : 0.6)

Repeater {
model: hasHardwareAcceleration ? 1 : 0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Swiftb0y this is where that setting is used. Without this switch, the Windows VM I used to test (which has software acceleration) will max out CPU when opening the popup.
Now I don't want to degrade the look of the new interface just to accommodate unorthodox setup (e.g testing VM) but going forward, we will need to support weaker setups if that makes sense

@acolombier acolombier requested a review from Swiftb0y May 12, 2025 18:53
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise. Thank you.

@acolombier acolombier force-pushed the feat/qml-settings branch from f6cee98 to 993f8ab Compare May 12, 2025 19:25
@acolombier
Copy link
Member Author

Done and squashed!

@acolombier acolombier requested a review from Swiftb0y May 12, 2025 19:26
@Swiftb0y
Copy link
Member

build fails... I'm pretty sure QNamespace is not a thing. <qnamespace> is probably a transient private dependency in QObject and you want to include the latter instead.

@acolombier acolombier force-pushed the feat/qml-settings branch from 993f8ab to a2e7ef0 Compare May 12, 2025 22:18
@acolombier
Copy link
Member Author

It is indeed <Qt>! I updated after the build failed locally, but I didn't save before committing... 😅

@acolombier acolombier force-pushed the feat/qml-settings branch from a2e7ef0 to e7c8a79 Compare May 12, 2025 22:19
@acolombier
Copy link
Member Author

Now failing due to issues mitigated by #14740

Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Swiftb0y Swiftb0y merged commit 58d1501 into mixxxdj:main May 13, 2025
12 of 13 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in QML GUI May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants