-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: add QML setting popup #14568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add QML setting popup #14568
Conversation
1fe8d69
to
99ad935
Compare
3ec8f11
to
e053834
Compare
e053834
to
36317c0
Compare
3f7eabe
to
5c31c41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple thoughts. overall pretty nice. Building locally right now to sanity test.
pre-commit failures depend on qarmin/qml_formatter#7 |
color: Qt.alpha('#00000010', hasHardwareAcceleration ? 1.0 : 0.6) | ||
|
||
Repeater { | ||
model: hasHardwareAcceleration ? 1 : 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Swiftb0y this is where that setting is used. Without this switch, the Windows VM I used to test (which has software acceleration) will max out CPU when opening the popup.
Now I don't want to degrade the look of the new interface just to accommodate unorthodox setup (e.g testing VM) but going forward, we will need to support weaker setups if that makes sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise. Thank you.
f6cee98
to
993f8ab
Compare
Done and squashed! |
build fails... I'm pretty sure QNamespace is not a thing. |
993f8ab
to
a2e7ef0
Compare
It is indeed |
a2e7ef0
to
e7c8a79
Compare
Now failing due to issues mitigated by #14740 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you.
Add QML setting section popup. Note that the legacy setting window can still be displayed by long pressing the setting button.
This also add a setup to allow setting search. Currently, setting search activation will automatically activate the setting in the UI, but it is also to bind the
Mixxx.SettingGroup.onActivated
signal to add more animation (e.g to highligh an input/output in the soundgraph)