feat: Prefer stub over target object if not the same kind #422
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reviewers
Description of the change
This update changes the behavior of handling stub packages when encountering a target object and stub that are of a different kind.
griffeno longer skips the stub in this case, and instead prefers the stub over the target.Successfully tested on my current documentation project wherein
griffewas seeing aclassobject as amodule-attribute, and with the change, is successfully rendering it as aclasswith the expected docstring from a.pyifile.Both
make checkandmake testare not working for me. If desired, I can provide the failure details. I'm including this to note that neither were run before submitting this PR.Relevant resources
mkdocstringsdiscussion 803: Stubs package configuration for `mkdocstrings` mkdocstrings#803