Allow request mappings to handle a request based on host#123
Open
jwgmeligmeyling wants to merge 1 commit into
Open
Allow request mappings to handle a request based on host#123jwgmeligmeyling wants to merge 1 commit into
jwgmeligmeyling wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #123 +/- ##
============================================
- Coverage 90.80% 90.58% -0.23%
- Complexity 542 544 +2
============================================
Files 167 167
Lines 1849 1858 +9
Branches 54 55 +1
============================================
+ Hits 1679 1683 +4
- Misses 148 152 +4
- Partials 22 23 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sgmeligmeyling
approved these changes
May 28, 2021
mkopylec
requested changes
Jun 1, 2021
Owner
mkopylec
left a comment
mkopylec
left a comment
There was a problem hiding this comment.
Same thing must be done for webflux module
mkopylec
requested changes
Jun 1, 2021
Owner
mkopylec
left a comment
mkopylec
left a comment
There was a problem hiding this comment.
Unit tests for this feature must be added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #121