Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lcrypto.c] Fix memory leak in x509__load_cert #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[lcrypto.c] Fix memory leak in x509__load_cert #43

wants to merge 1 commit into from

Conversation

tkoeppe
Copy link

@tkoeppe tkoeppe commented May 24, 2016

No description provided.

@palmerabollo palmerabollo mentioned this pull request Oct 30, 2017
Open
@tecnobrat
Copy link

If I'm understanding the code properly, this is not the only place that doesn't free up that memory.

Its also not freed in pkey_from_pem and pkey_to_pem.

@tkoeppe
Copy link
Author

tkoeppe commented Jan 2, 2018

Possibly. I only detected the leak dynamically via ASAN, so I would have missed code that wasn't executed.

@Tieske
Copy link

Tieske commented Jan 3, 2018

for reference: Kong/kong#2194 (comment)

@rsbrisci
Copy link

I can confirm we are also seeing huge memory leak issues in pkey_from_pem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tkoeppe @tecnobrat @Tieske @rsbrisci