Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the binary size by moving the kernel dispatches to an outer level and adding back
unsafe_weak_copy
:Binary size built with:
Pre: 35MB
Post: 11MB (potentially shrink more by updating a few more of the Primitives with the new pattern)
Benchmarks
These are some pretty lightweight CPU benchmarks to try and get at overhead. For anything larger the time differences aren't visible.