Skip to content

feat: add dictionaryOnly mode for background-safe G2P #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
integrITsolutions wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add dictionaryOnly mode for background-safe G2P #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions Sources/MisakiSwift/English/EnglishG2P.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@ final public class EnglishG2P {
private let lexicon: Lexicon
private let fallback: EnglishFallbackNetwork
private let unk: String

/// When `true`, skips MLX BART fallback for OOV words. Pure Swift dictionary
/// lookups (179K entries) still run. Use in iOS background mode where Metal
/// GPU is unavailable. OOV words will have nil phonemes.
public var dictionaryOnly: Bool = false

static let punctuationTags: Set<NLTag> = Set([.openQuote, .closeQuote, .openParenthesis, .closeParenthesis, .punctuation, .sentenceTerminator, .otherPunctuation])
static let punctuactions: Set<Character> = Set(";:,.!?—…\"“”")
Expand Down Expand Up @@ -416,7 +421,7 @@ final public class EnglishG2P {
w.`_`.rating = out.1
}

if w.phonemes == nil {
if w.phonemes == nil && !dictionaryOnly {
let out = fallback(w)
w.phonemes = out.0
w.`_`.rating = out.1
Expand Down Expand Up @@ -461,7 +466,7 @@ final public class EnglishG2P {
}
}

if shouldFallback {
if shouldFallback && !dictionaryOnly {
let token = mergeTokens(arr)
let first = arr[0]
let out = fallback(token)
Expand Down