Skip to content

feat: ✨ create macmon class for Mac monitoring #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

feat: ✨ create macmon class for Mac monitoring #752

wants to merge 21 commits into from

Conversation

LuisBlanche
Copy link
Contributor

@LuisBlanche LuisBlanche commented Dec 20, 2024 •
edited
Loading

fixes #731

@LuisBlanche LuisBlanche linked an issue Dec 20, 2024 that may be closed by this pull request
Sudoless power metrics on Apple Silicon #731
Open
@LuisBlanche LuisBlanche self-assigned this Dec 20, 2024
@LuisBlanche LuisBlanche marked this pull request as ready for review December 21, 2024 11:25
@LuisBlanche
Copy link
Contributor Author

Need to update the docs to add macmon installation

benoit-cty
benoit-cty reviewed Dec 22, 2024
View reviewed changes
@LuisBlanche LuisBlanche mentioned this pull request Jan 17, 2025
Open
@LuisBlanche
Copy link
Contributor Author

Waiting for vladkens/macmon#20 answer to see if there is something wrong with ram_power measurement

@LuisBlanche LuisBlanche added the enhancement New feature or request label Feb 8, 2025
@KennethEnevoldsen
Copy link

HI @LuisBlanche any update on this one - we would love to have it over on MTEB

@LuisBlanche
Copy link
Contributor Author

We have an issue where RAM power is not correctly measured by macmon on M1 chips. I am currently discussing this with the maintainer. I can probably adapt the code so that it does not use macmon for RAM with M1

@KennethEnevoldsen
Copy link

Alright, no stress just wanted to to know whether it had gotten stale

@ElliottKasoar ElliottKasoar mentioned this pull request Mar 25, 2025
Merged
@LuisBlanche
Copy link
Contributor Author

@benoit-cty I have updated this and I think it is ready to merge. It just needs a review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoit-cty benoit-cty benoit-cty left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@LuisBlanche LuisBlanche

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sudoless power metrics on Apple Silicon
3 participants
@LuisBlanche @KennethEnevoldsen @benoit-cty