fix: improve cli error-handling #798
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaboniAmine
approved these changes
Mar 11, 2025
| @@ -223,6 +228,9 @@ def config(): | |||
| description=org_description, | |||
| ) | |||
| organization = api.create_organization(organization=organization_create) | |||
| if organization is None: | |||
| print("Error creating organization") | |||
There was a problem hiding this comment.
Can we get a functional error returned to the user, from the create_organization method ?
There was a problem hiding this comment.
Sure! Issue is in the api_client we are hiding all the errors (maybe this is intended?) see --> https://github.com/mlco2/codecarbon/blob/master/codecarbon/core/api_client.py#L137
There was a problem hiding this comment.
I think this was made to avoir showing some technical errors to the user, which could bring confusion.
We might have more functional errors, wrapping the technical ones to give hints to the user on how to fix the problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor tweaks to the cli to handle better the errors