Fix result selection #206
Merged
Fix result selection #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not change functionality but simplifies logic of `render_image` callback
…ent data Previously, `render_image` was only called when: - the image slice index changed (this is also triggered when a new data set is loaded, even if the slide index remains the same) - the overlay toggle is used Since this was not dependent on changes of results (e.g. a inference or training job is selected), it can happen that outdated result information is shown if the overlay toggle was not toggled in between switching jobs. Inference results from other data sets, also Partially adresses mlexchange#188, adresses mlexchange#190 The drop-downs being used both as result selection and as state trackers for jobs complicates this.
|
Review these changes at https://app.gitnotebooks.com/mlexchange/mlex_highres_segmentation/pull/206 |
xiaoyachong
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to the result selection and display. This includes:
render_imagecallback and callbacks that store training and inference result to ensure that shown data and shown inference result match (Segmentation results remain on display after switching dataset #188 is partially addressed, resolves Inference results persist as overlay even after new training job submission #190). The refactor ofrender_imageincluded separating out the jumping to annotated slices into a dedicated callbackpopulate_segmentation_resultsto provide user notifications when segmentation results are unavailable, either due to failed training/inference or mismatched image URIs. (resolves Result retrieval does not properly handle failed flows #203)clearableandsearchableoptions to bothtrain-job-selectorandinference-job-selectorto allow users to easily clear and search jobs in the dropdowns. Theclearableoption is a bit of a work-around to a user having selected running job, that then completes. This doesn't trigger any result overlay callbacks (since the data changes, but not the value, as the value is equal to the flow uuid), as we do not explicitly monitor and act on state changes in the currently selected valueInterestingly, I can now no longer reproduce #204.