Skip to content

Conversation

@Wiebke
Copy link
Member

@Wiebke Wiebke commented Dec 5, 2025

This PR performs several maintenance updates and fixes:

  • Upgrade Tiled to 0.2.0
    No code changes needed as functions for retrieving data and writing arrays have the same signature

  • Upgrade Dash to 2.18.1
    This is the final release of Dash v2. The update restores the ability to delete shapes (see Dash version needs to be > 2.12.0 #205), but also reintroduces the issue where annotations disappear on resize. This strongly points to the introduction of deleteActiveShape having something to do with annotations disappearing on resizing.

  • Fix annotation writing error due to missing export directory
    If EXPORT_FILE_PATH points to a directory that doesn't yet exist, the application will fail to write annotations.

@Wiebke Wiebke requested review from taxe10 and xiaoyachong December 5, 2025 17:31
Copy link
Member

@taxe10 taxe10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me. I haven't tested it yet, but I was wondering if we should add the master docker compose file to this PR with the accompanying change of tiled version? So we can archive mlex_tomo_framework

@Wiebke
Copy link
Member Author

Wiebke commented Dec 5, 2025

Sure, that sounds like a good idea. I was working on compose improvements here for the moment: https://github.com/mlexchange/mlex_tomo_framework/tree/compose-improvements

@Wiebke
Copy link
Member Author

Wiebke commented Dec 10, 2025

Deferring the docker-compose.yml to a later PR.

@Wiebke Wiebke merged commit 1774814 into main Dec 10, 2025
2 checks passed
@Wiebke Wiebke deleted the tiled-update-minor-deployment-fixes branch December 10, 2025 16:02
@xiaoyachong
Copy link
Contributor

Hi @Wiebke, may I ask whether the compose-improvements branch (https://github.com/mlexchange/mlex_tomo_framework/tree/compose-improvements) needs to be merged to stay compatible with the current main branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants