Skip to content

fix: allow optional customize fields to keep defaults#90

Merged
TomKaltofen merged 1 commit into
mloda-ai:mainfrom
hkJerryLeung:fix/customize-optional-placeholders
Jul 15, 2026
Merged

fix: allow optional customize fields to keep defaults#90
TomKaltofen merged 1 commit into
mloda-ai:mainfrom
hkJerryLeung:fix/customize-optional-placeholders

Conversation

@hkJerryLeung

Copy link
Copy Markdown
Contributor

Summary

Fixes #84. bin/customize.sh <package> now succeeds when optional author, email, and description flags are omitted, while still rejecting unexpected leftover placeholder references.

Changes

  • Filter only the documented default authors and description fields when their optional flags were not supplied.
  • Keep stale-reference detection strict for package files, entry points, and all other customized fields.
  • Add end-to-end tests for the no-optional-flags path and an intentionally stale entry point.

Verification

  • uv run tox — 21 tests passed; Ruff format/check, mypy strict, and bandit all passed.
  • bash -n bin/customize.sh — passed.
  • Commit author and committer: hkJerryLeung <hkjerryleung@gmail.com>.

@TomKaltofen

Copy link
Copy Markdown
Contributor

@hkJerryLeung Thank you for your contribution, I appreciate this a lot!

@TomKaltofen
TomKaltofen merged commit 8c52570 into mloda-ai:main Jul 15, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Need support]: Fix customize.sh stale check failing when optional flags are omitted

2 participants