Install libpcsclite for the dry-run CLI build - #13
Merged
Merged
Conversation
The framework CLI links pcsc through LEZ v0.2.4's wallet crate, so the dry-run job's build of it needs libpcsclite-dev on the runner, the same package upstream installs before every CLI build. The dry-run scripts sent the build's stderr to /dev/null and carried on, which turned a missing system library into five "No such file" lines against a binary that was never built. The build's stderr now goes to a temp log that is printed on failure, and the script exits there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dry-run job on main failed after the framework moved to 8183b01: the CLI at that rev links pcsc through LEZ v0.2.4's wallet crate, and the runner has no libpcsclite. Upstream's CI installs libpcsclite-dev before every CLI build, this job now does the same.
The scripts also hid the cause. The CLI build's stderr went to /dev/null and the script kept going, so the log showed five "No such file" lines instead of the linker error. The build's stderr now lands in a temp log that is printed on failure, and the script exits at that point. Captures are unchanged on success, verified byte for byte locally.