WIP: Make clear distinction between "GC" and "pauses" #1397
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we introduced concurrent GC, one stop-the-world pause no longer corresponds to one GC, and the distinction between a "GC" and a "pause" becomes important.
We changed
GcStatus
toPauseState
, and its membersNotInPause
,PauseTriggered
andMutatorsStopped
are now used to describe pauses with respect to mutators, instead of GC phases. We also renamedset_gc_status
topause_state_transition
to emphasize that it is not merely setting the state, but also triggering events.We changed the statistics output "GC" to "pauses".
TODO:
GCWorkScheduler::on_gc_finished
andPlan::end_of_gc
, should be either renamed toxxx_pause_xxx
, or refactored to ensure that they are called at actual ends of GCs instead of end of pauses.