Allow overriding ScanObjects packet size #990
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works around a load balancing problem where the default packet size 4096 is too large for some work loads, resulting in a low level of parallelism.
|
I don't know how useful it would be to allow bindings to have a globally defined capacity for scan objects work. The right capacity should highly depend on the workload and what type of objects that are in the packets. It should not depend on what language it is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around a load balancing problem where the default packet size 4096 is too large for some work loads, resulting in a low level of parallelism.
In the long run, we should support work stealing to properly fix the problem.