-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: client generators support experimental runtime response validation #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnahkies
added a commit
that referenced
this pull request
Dec 2, 2023
this will allow them to be used in client templates (eg: #112)
mnahkies
added a commit
that referenced
this pull request
Dec 2, 2023
to later be used for use-cases like #112 unfortunately it's not smart enough to only output schemas that are actually being used so creates a bit of noise at the moment.
2ceb67d
to
88ff2b1
Compare
c05c422
to
5e654c8
Compare
e0706b5
to
2a4ac10
Compare
wip example of adding response validation using `zod`/`joi`/etc to client templates using the axios generator
97371a2
to
4d6e899
Compare
mnahkies
added a commit
that referenced
this pull request
Feb 17, 2024
follow up to #112 that adds `joi` support for client response validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for (optional) runtime response validation using
zod
for thetypescript-fetch
andtypescript-axios
client builders, enabled using the--enable-runtime-response-validation
cli flag.Currently considered experimental and probably buggy.
Additionally fixed some incorrect return types for the
typescript-axios
template, and made emptyschema
files stop being output.Partially implements #82
TODO
Probably not to be completed in this PR, but these are roughly the outstanding actions before it would be considered stable
joi
typescript-angular
Example output
typescript-fetch
typescript-axios