fix(client-sdks): handle 204 empty responses with runtime validation #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds e2e tests for endpoints returning
204/ empty responses and relaxes runtime schema validation for clients to useany, allowing foraxiosreturning an""Keeps the type as
voidwhich is somewhat a lie, but I believe a pragmatic decision - in practice you shouldn't be looking at the response body for a204at all, so it shouldn't really matter. Thefetchclient will continue to throw a JSON parse error if you attempt to read the empty response, which I think is fine for the same reason.An alternative might've been to use a
.transform(it => undefined)to coerce the runtime value toundefinedbut I don't think there is all that much value in this.closes #285