Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
SymbolicBitinternally has pointers, though the bit itself is not a pointer. This meantx.clone() ^ xwould in general not evaluate to false, because the cloned value is a distinct object.To remedy this the
BitAndoperator (the fundamental operation underlying all others) has been updated to check forx & xas well asx & !x. Note that this only checks whether the immediate arguments are either the same pointer or the same symbolic variable. It does not do attempt to check whether the circuit is identical.Confirmed
x ^ xnow evaluates tofalseeven whenxis a complex object.This required bumping the MSRV to 1.88 that's when certain patterns of
if-letchains were stabilized: rust-lang/rust#53667