Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 New environment variables: DB path / Public path / Show OPEN API #307

Merged
merged 4 commits into from
Feb 10, 2025

Conversation

brunobuddy
Copy link
Contributor

@brunobuddy brunobuddy commented Feb 10, 2025

Description

This PR adds 3 new environment variables to Manifest:

DATABASE_PATH
PUBLIC_PATH
OPEN_API_DOCS

There is no doc PR yet as it will be created later depending on the experience deploying manifest to several hosting providers.

The main goal is to be able to put files that need persistent data (db+ storage) in the same folder.

Related Issues

How can it be tested?

Create a new folder next to public and call it disk for example (targeting Render Disks) and add the following variables in your dotenv:

DATABASE_PATH=./disk/db/new.db
PUBLIC_FOLDER=./disk/public

Restart and test to store data, files and images. Everything should work.

For the API DOC, set OPEN_API_DOCS=false in dotenv to disable it

Check list before submitting

  • This PR is wrote in a clear language and correctly labeled
  • I created the related changeset for my changes with npx changeset
  • I have performed a self-review of my code (no debugs, no commented code, good naming, etc.)
  • I wrote the relative tests
  • I created a PR for the documentation if necessary and attached the link to this PR

Copy link

codecov bot commented Feb 10, 2025

Bundle Report

Bundle size has no change ✅

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.67%. Comparing base (c838305) to head (e05bd4d).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #307   +/-   ##
=======================================
  Coverage   65.67%   65.67%           
=======================================
  Files          51       51           
  Lines        1451     1451           
  Branches      331      331           
=======================================
  Hits          953      953           
+ Misses        496      458   -38     
- Partials        2       40   +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brunobuddy brunobuddy marked this pull request as ready for review February 10, 2025 10:51
@brunobuddy brunobuddy requested a review from SebConejo February 10, 2025 10:52
@brunobuddy brunobuddy self-assigned this Feb 10, 2025
@SebConejo SebConejo assigned SebConejo and unassigned brunobuddy Feb 10, 2025
@SebConejo SebConejo merged commit 52a0094 into master Feb 10, 2025
6 checks passed
@SebConejo SebConejo deleted the env-paths branch February 10, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants