fix(client): preserve Request options in proxy fetch#1477
Open
go165 wants to merge 1 commit into
Open
Conversation
285cf91 to
3746d53
Compare
Author
|
Validation update for the latest head
GitHub reports the pushed commit signature as verified. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
new Request(input, init)before serializing them for/fetchRequestmethod, headers, and body instead of forwarding onlyRequest.urlRequestinputs and explicitinitoverridesCloses #1207.
Validation
git diff --check/home/ubuntu/modelcontextprotocol-inspector/clients/web/node_modules/.bin/prettier --check client/src/lib/proxyFetch.ts client/src/lib/__tests__/proxyFetch.test.tsnew Request()preserves POST method, lower-cased headers, and text body for the reported Request-input caseI attempted the focused Jest command
npm test -- --runTestsByPath src/lib/__tests__/proxyFetch.test.ts --runInBand, but this fresh worktree did not havejestinstalled. A scopednpm ci --workspace=client --include-workspace-root=false --ignore-scriptsthen failed on registry download withECONNRESETforxml-name-validator-4.0.0.tgz, so I did not keep retrying registry downloads.