fix: Validate JSON parameters before tool execution #528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nandsha
changed the title
Prevents execution of tools with invalid JSON parameters by validating JSON syntax before tool execution and showing error UI for invalid input. - Add validateJson method to DynamicJsonForm via forwardRef - Add validation check in ToolsTab before tool execution - Reuse existing JsonEditor error display for consistent UX
nandsha
force-pushed
the
fix/validate-json-on-tool-execution
branch
from
c524a16 to
d65ed01
Compare
|
Hi @nandsha thanks for this PR! Just wanted to give a heads up: we recently merged in a fairly large set of changes to the JSON schema handling behind the scenes, so I'm taking a little time to go through regression scenarios from other past issues before merging in more large changes to tool input validation. Will dig into this one next. |
Integrate JSON validation with copy JSON functionality: - Maintain forwardRef structure for validation exposure - Combine copy button with validation method - Both features working together without conflicts
|
Resolved merge conflicts and tested successfully. Thanks @olaservo |
- Merged JSON validation functionality from PR branch with enhanced form features from main - Preserved validateJson method and DynamicJsonFormRef interface for tool validation - Added support for oneOf schemas, enum dropdowns, and enhanced string field types - Integrated meta display functionality and resource content props - Maintained JSON validation before tool execution to prevent invalid data submission
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Motivation and Context
Prevents execution of tools with invalid JSON parameters by validating JSON syntax before tool execution and showing error UI for invalid input.
How Has This Been Tested?
Yes
mcp-inspector-fix-for-issue-498.mov
Breaking Changes
No breaking changes
Types of changes
Checklist