Skip to content

feat: Added AutoCloseable interface #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

YunKuiLu
Copy link

I've added the AutoCloseable interface to the following classes to support the try-with-resources statement:

  • LifecycleInitializer
  • McpAsyncClient
  • McpAsyncServer
  • McpServerTransportProvider
  • McpSession
  • McpSyncServer
  • McpTransport
  • McpTransportSession

Motivation and Context

In order to support the try-with-resources block for these classes.

How Has This Been Tested?

N/A

Breaking Changes

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Added AutoCloseable interface to:
- LifecycleInitializer
- McpAsyncClient
- McpAsyncServer
- McpServerTransportProvider
- McpSession
- McpSyncServer
- McpTransport
- McpTransportSession
for support try-with-resources block.

Signed-off-by: YunKui Lu <[email protected]>
@YunKuiLu YunKuiLu marked this pull request as ready for review July 14, 2025 17:37
Copy link
Contributor

@134130 134130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, current close() means immediately shutdown, and closeGracefully() is the graceful shutdown.

AutoClosable should be graceful shutdown as default, as ExecutorService does. see: https://stackoverflow.com/questions/41393417/why-does-the-executorservice-interface-not-implement-autocloseable

@YunKuiLu
Copy link
Author

YunKuiLu commented Jul 17, 2025

IMHO, current close() means immediately shutdown, and closeGracefully() is the graceful shutdown.

AutoClosable should be graceful shutdown as default, as ExecutorService does. see: https://stackoverflow.com/questions/41393417/why-does-the-executorservice-interface-not-implement-autocloseable

Learned something new again! I’m thinking — would it make sense to introduce a closeNow() method to replace the current close(), and update the existing close() to call this.closeGracefully().subscribe()? ( like ExecutorService.shutdownNow() )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants