-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Handle Abrupt Server Disconnect in Middle of Tool Call #1321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
EiffL
wants to merge
5
commits into
modelcontextprotocol:main
Choose a base branch
from
EiffL:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+84
−1
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
671d077
fix: handle transport exceptions and ensure proper cleanup of in-flig…
EiffL de6dd61
Merge pull request #1 from EiffL/streamable_http_disconnect
EiffL c5bce60
Applying formatting
EiffL 3c1d164
Merge branch 'main' into main
EiffL 2e6bc0e
Merge branch 'main' into main
EiffL File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -336,7 +336,21 @@ async def _receive_loop(self) -> None: | |
try: | ||
async for message in self._read_stream: | ||
if isinstance(message, Exception): | ||
# Transport-level exception. Forward it to the incoming | ||
# handler for logging/observation, then fail all | ||
# in-flight requests so callers don't hang forever. | ||
await self._handle_incoming(message) | ||
error = ErrorData(code=CONNECTION_CLOSED, message=str(message)) | ||
# Send error to any pending request response streams immediately | ||
for id, stream in list(self._response_streams.items()): | ||
try: | ||
await stream.send(JSONRPCError(jsonrpc="2.0", id=id, error=error)) | ||
await stream.aclose() | ||
except Exception: | ||
pass | ||
self._response_streams.clear() | ||
# Break out of the receive loop; connection is no longer usable. | ||
break | ||
Comment on lines
+339
to
+353
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This seems like a duplication of all the logic we have at the bottom of The changes here also don't seem necessary to make the tests you added pass - do we need this? |
||
elif isinstance(message.message.root, JSONRPCRequest): | ||
try: | ||
validated_request = self._receive_request_type.model_validate( | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closing on any type of exception seems to broad - we should be more explicit about the failure cases that definitely mean the session is unusable, there might be recoverable errors.