-
Notifications
You must be signed in to change notification settings - Fork 2.8k
add an example for homebrew style file upload #1637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add an example for homebrew style file upload #1637
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please don't commit PDFs to this repo, they're large binary files and often considered not secure to open unless trusted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I will remove the pdf file this week. it's mid night my local time today.
Signed-off-by: SamYuan1990 <[email protected]>
Signed-off-by: SamYuan1990 <[email protected]>
Signed-off-by: SamYuan1990 <[email protected]>
Signed-off-by: SamYuan1990 <[email protected]>
Signed-off-by: SamYuan1990 <[email protected]>
Signed-off-by: SamYuan1990 <[email protected]>
16e5fef to
3a25a01
Compare
Signed-off-by: SamYuan1990 <[email protected]>
Signed-off-by: SamYuan1990 <[email protected]>
Signed-off-by: SamYuan1990 <[email protected]>
Signed-off-by: SamYuan1990 <[email protected]>
|
hi @maxisbey , as you have my word, I just updated this example as remove pdf files and pass CI checks. Would you like to give it a review? |
|
I won't be reviewing this as it's not something we can merge. As mentioned in the linked issue, this would require a SEP to be accepted and merged into a draft spec of MCP. Unfortunately I don't have time to do code reviews for things that aren't able to be merged :( The SEP I'm guessing this is following, modelcontextprotocol/modelcontextprotocol#1306, hasn't yet been accepted and would need to be before any maintainers would look at adding this to the Python SDK. Going to switch this PR to a draft for now. |
Motivation and Context
an example for modelcontextprotocol/modelcontextprotocol#1306 from modelcontextprotocol/modelcontextprotocol#1522
address #1590
How Has This Been Tested?
see document as readme of this PR.
Breaking Changes
n/A
Types of changes
Checklist
Additional context