Skip to content

Conversation

@SamYuan1990
Copy link

Motivation and Context

an example for modelcontextprotocol/modelcontextprotocol#1306 from modelcontextprotocol/modelcontextprotocol#1522
address #1590

How Has This Been Tested?

see document as readme of this PR.

Breaking Changes

n/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't commit PDFs to this repo, they're large binary files and often considered not secure to open unless trusted

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I will remove the pdf file this week. it's mid night my local time today.

Signed-off-by: SamYuan1990 <[email protected]>
Signed-off-by: SamYuan1990 <[email protected]>
Signed-off-by: SamYuan1990 <[email protected]>
Signed-off-by: SamYuan1990 <[email protected]>
Signed-off-by: SamYuan1990 <[email protected]>
Signed-off-by: SamYuan1990 <[email protected]>
Signed-off-by: SamYuan1990 <[email protected]>
Signed-off-by: SamYuan1990 <[email protected]>
@SamYuan1990 SamYuan1990 marked this pull request as ready for review November 20, 2025 06:21
@SamYuan1990
Copy link
Author

hi @maxisbey , as you have my word, I just updated this example as remove pdf files and pass CI checks. Would you like to give it a review?

@maxisbey
Copy link
Contributor

I won't be reviewing this as it's not something we can merge. As mentioned in the linked issue, this would require a SEP to be accepted and merged into a draft spec of MCP. Unfortunately I don't have time to do code reviews for things that aren't able to be merged :(

The SEP I'm guessing this is following, modelcontextprotocol/modelcontextprotocol#1306, hasn't yet been accepted and would need to be before any maintainers would look at adding this to the Python SDK.

Going to switch this PR to a draft for now.

@maxisbey maxisbey marked this pull request as draft November 20, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants