Repository navigation
fix(stdio): allow configurable memory stream buffer size - #2215
Closed
yaowubarbara wants to merge 3 commits into
Closed
yaowubarbara wants to merge 3 commits into
yaowubarbara wants to merge 3 commits into
Conversation
Add read_stream_buffer_size and write_stream_buffer_size parameters to stdio_server() to allow decoupling the stdin reader from the message processor. With the default buffer_size=0, the reader blocks on send() until the processor consumes the message, causing the server to become unresponsive during slow operations. A non-zero buffer allows the reader to queue messages ahead, preventing ping timeouts and request starvation. Closes modelcontextprotocol#1333
The two new buffer tests did not close write_stream, causing stdout_writer to block indefinitely on write_stream_reader iteration. This prevented the task group from exiting, hanging the test until CI timeout.
Contributor
|
Thanks for the PR, and sorry it sat here without a proper review. We're closing most of the open PR backlog. v2 is out and changed a lot of the SDK, so many older PRs no longer apply as written, and we're a small team that realistically doesn't have the capacity to work through the rest. If this still matters to you on v2, the most useful thing you can do is open an issue (or comment on the existing one) with your use case and a repro. Hearing why it matters to you is what we use to decide what to prioritise. |
maxisbey
added
the
missing-issue-link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add and parameters to to decouple the stdin reader from the message processor.
Problem
With the current hardcoded in , the stdin reader blocks on until the message processor calls . When processing is slow (database queries, API calls), the reader cannot accept new messages including pings, causing the server to become unresponsive. See #1333 for details.
Solution
Test plan
Closes #1333