Conversation
|
Follow-up pushed for the remaining CI coverage gate. The failed matrix jobs were passing tests but reporting two uncovered lines ( Local validation on the updated branch:
|
|
One more narrow follow-up pushed: the next Ubuntu run reached 100% coverage, then strict-no-cover correctly reported that the Additional local validation:
|
|
Thank you. Is there anything that blocks this PR? I'd really like to remove the required monkeypatching of |
|
Thanks for the PR, and sorry it sat here without a proper review. We're closing most of the open PR backlog. v2 is out and changed a lot of the SDK, so many older PRs no longer apply as written, and we're a small team that realistically doesn't have the capacity to work through the rest. If this still matters to you on v2, the most useful thing you can do is open an issue (or comment on the existing one) with your use case and a repro. Hearing why it matters to you is what we use to decide what to prioritise. |
|
Sigh Yes it still matters! A lot, in fact. See my comment on the issue. |
Fixes #1656.
Summary
MCPServer.__init__mcp runCLI entrypoint instead, where the process is owned by the SDK CLIValidation
uv run ruff format --check src/mcp/cli/cli.py src/mcp/server/mcpserver/server.py tests/cli/test_utils.py tests/server/mcpserver/test_server.pyuv run ruff check src/mcp/cli/cli.py src/mcp/server/mcpserver/server.py tests/cli/test_utils.py tests/server/mcpserver/test_server.pyuv run pyright src/mcp/cli/cli.py tests/cli/test_utils.py tests/server/mcpserver/test_server.pyuv run pytest tests/cli/test_utils.py tests/server/mcpserver/test_server.py -qgit diff --check