Repository navigation
Conversation
There was a problem hiding this comment.
No issues found across 2 files
Tip: cubic could auto-approve low-risk PRs like this, if it thinks it's safe to merge. Learn more
Re-trigger cubic
|
Hi maintainers — checking whether this small validation-error clarification is still useful. The branch is currently mergeable, and the latest recorded CI, conformance, and security checks are green. I can rebase or adjust the wording if the validation contract has moved since this was opened. If the scope is no longer desired, please let me know and I can close it. |
6558dc9 to
b455f81
Compare
|
Thanks for the PR, and sorry it sat here without a proper review. We're closing most of the open PR backlog. v2 is out and changed a lot of the SDK, so many older PRs no longer apply as written, and we're a small team that realistically doesn't have the capacity to work through the rest. If this still matters to you on v2, the most useful thing you can do is open an issue (or comment on the existing one) with your use case and a repro. Hearing why it matters to you is what we use to decide what to prioritise. |
Summary
tool_use/tool_resultbalance validation strictValueErrortool_usefollowed by user text instead oftool_resultRelated to #2960. This PR does not relax the balance rule; it only makes the diagnostic distinguish a missing
tool_resultfrom an ID mismatch when atool_useis followed by a non-result message.Tests
uv run --frozen pytest tests/server/test_validation.py -quv run --frozen ruff check src/mcp/server/validation.py tests/server/test_validation.pyuv run --frozen ruff format --check src/mcp/server/validation.py tests/server/test_validation.pygit diff --check