Skip to content

Replace RootModel wrappers with type aliases and TypeAdapter validation - #3470

Merged
Kludex merged 1 commit into
mainfrom
codex/remove-root-models
Sep 7, 2026
Merged

Kludex merged 1 commit into
mainfrom
codex/remove-root-models

Replace RootModel wrappers with type aliases and TypeAdapter validation

b4030ab
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Sep 7, 2026 in 9m 31s

Code review found 1 important issue

Found 3 candidates, confirmed 1. See review comments for details. 2 verified lower-impact observations (convention, logging or cleanup points) were not posted.

Details

Severity Count
🔴 Important 1
🟡 Nit 0
🟣 Pre-existing 0
Severity File:Line Issue
🔴 Important src/mcp/server/mcpserver/utilities/func_metadata.py:511 For 'dict[str, T]'-returning tools, the documented public field 'FuncMetadata.output_model' now holds an 'Annotated[...]