Skip to content

Validate an explicit null structuredContent against the output schema - #3621

Merged
maxisbey merged 1 commit into
mainfrom
3345-null-structured-content
Oct 2, 2026
Merged

maxisbey merged 1 commit into
mainfrom
3345-null-structured-content

Validate an explicit null structuredContent against the output schema

9026b41
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Oct 2, 2026 in 6m 20s

Code review found 4 potential issues

Found 7 candidates, confirmed 4. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 4
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit tests/client/test_session.py:1833 Maintainers get three new raw-wire tests whose docstrings do not say why the public API could not produce the input, whi
🟡 Nit src/mcp/client/session.py:1139 nit: AGENTS.md says any change to an existing public API's observable behaviour is a maintainer design decision that sho
🟡 Nit src/mcp/client/session.py:1139 nit: AGENTS.md requires a 'docs/' update in the same PR when a change affects user-visible behaviour: this line changes
🟡 Nit src/mcp/client/session.py:0 nit: PR checklist — AGENTS.md asks that 2026-07-28 spec behaviour have a matching conformance-suite scenario that pass