Skip to content

Document how a handler deals with cancellation - #3625

Merged
maxisbey merged 2 commits into
mainfrom
3389-cancellation-docs
Oct 2, 2026
Merged

maxisbey merged 2 commits into
mainfrom
3389-cancellation-docs

Show cleanup in a finally in the plain def cancellation example

e25d6ae
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Oct 2, 2026 in 24m 47s

Code review found 3 potential issues

Found 10 candidates, confirmed 3. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 3
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit tests/docs_src/test_cancellation.py:67 Every run of the suite pays a fixed 'anyio.sleep(0.1)' in each of the six tutorial001 test arms, a timing wait the repos
🟡 Nit tests/docs_src/test_cancellation.py:213 nit: maintainers triaging a future failure of this pinned-gap test get no tracking issue to consult, and the docstring r
🟡 Nit mkdocs.yml:43 nit: AGENTS.md Documentation says to find the page in 'mkdocs.yml' covering the feature rather than adding a new one: th