Add flags for publish subcommand #771
Open
+18
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@domdomegg @rdimitrov I am unable to add reviewers to this PR (and wasn't sure who should I request for reviews). Please take a look, thank you!! :) |
6 tasks
Yuan325
added a commit
to googleapis/genai-toolbox
that referenced
this pull request
Nov 18, 2025
## Description Temporarily move `server.json` out from the `.registry/` folder. The mcp-publisher library do not support the `--file` flag yet. A [PR](modelcontextprotocol/registry#771) was submitted to add flags for publish subcommand. ## PR Checklist > Thank you for opening a Pull Request! Before submitting your PR, there are a > few things you can do to make sure it goes smoothly: - [x] Make sure you reviewed [CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md) - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) - [x] Make sure to add `!` if this involve a breaking change 🛠️ Fixes #<issue_number_goes_here>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add flags for publish subcommand.
Motivation and Context
We'll need to use the
--fileflag since we store our server.json in a folder.The options that was noted in the docs here was not implemented. This PR added the 3 flags that was stated.
How Has This Been Tested?
Tested locally
Breaking Changes
No breaking changes. The existing way of defining file
mcp-publisher publish server.jsonwill still work.Types of changes
Checklist
Additional context
Fixes #767