-
Notifications
You must be signed in to change notification settings - Fork 486
Add DELETE method to the OpenAPI specification #782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| '500': | ||
| description: Internal server error | ||
| content: | ||
| application/json: | ||
| schema: | ||
| type: object | ||
| properties: | ||
| error: | ||
| type: string | ||
| example: "Failed to delete server version" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: it would be nice to return a 501 Not Implemented in case the server does not support server version deletion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I also added it to publish since we've missed it there too 👍
domdomegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - can we also add a line in the docs?
Signed-off-by: Radoslav Dimitrov <[email protected]>
Signed-off-by: Radoslav Dimitrov <[email protected]>
Signed-off-by: Radoslav Dimitrov <[email protected]>
9079c18 to
5ac24bf
Compare
Addressed 🚀 |
) <!-- Provide a brief summary of your changes --> ## Motivation and Context <!-- Why is this change needed? What problem does it solve? --> The following adds a DELETE method to the reference API specification of the registry. The endpoint is consistent with the rest of the spec and provides a standardised way for registry implementations to support deletion if they choose to. **Details:** * Endpoint: DELETE /v0/servers/{serverName}/versions/{version} * Uses tags: [publish] (same as POST /v0/publish for write operations) * Requires security: bearerAuth authentication * Returns ServerResponse on success (200) - matching POST pattern * Same error responses: 401 (Unauthorized), 403 (Forbidden), 500 (Internal error) * Added 404 (Not Found) for when server/version doesn't exist * Parameters match the GET endpoint format with URL-encoding examples * Marked as "(Optional)" in summary * Explicit note that it's not implemented by the official registry * States it's included for standardization purposes ## How Has This Been Tested? <!-- Have you tested this in a real application? Which scenarios were tested? --> ## Breaking Changes <!-- Will users need to update their code or configurations? --> ## Types of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. --> - [ ] I have read the [MCP Documentation](https://modelcontextprotocol.io) - [ ] My code follows the repository's style guidelines - [ ] New and existing tests pass locally - [ ] I have added appropriate error handling - [ ] I have added or updated documentation as needed ## Additional context <!-- Add any other context, implementation notes, or design decisions --> --------- Signed-off-by: Radoslav Dimitrov <[email protected]>
Motivation and Context
The following adds a DELETE method to the reference API specification of the registry.
The endpoint is consistent with the rest of the spec and provides a standardised way for registry implementations to support deletion if they choose to.
Details:
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context